If I understand properly, I found critical issue in the TUniGUIService

[Tokay]

Stop event from the system called the OnStart event in the TUniGUIService component.

I look in the IDE and see that call stack:

Vcl.SvcMgr.TService.DoStop

TUniGUIService._StopEvent

TTestService.UniGUIServiceStart

Please look at the issue urgently. Without correct stopping I could not work correctly in the service mode!

I have Delphi XE6, Windows 10, UniGUI 1545 env.

[Farshad Mohajeri]

Hello,

Can you elaborate more?

Do you call stop inside the OnStart event?

[Farshad Mohajeri]

Please send your code.

[Tokay]

I'll try to reproduce on the clean project

[Tokay]

unit ServiceModule;

interface

uses
 Windows, Messages, SysUtils, Classes, Graphics, Controls, SvcMgr, Dialogs,
 uniGUIService, System.IOUtils;

type
 TUniServiceModule = class(TUniGUIService)
  procedure UniGUIServiceDestroy(Sender: TObject);
  procedure UniGUIServiceCreate(Sender: TObject);
  procedure UniGUIServiceStart(Sender: TService; var Started: boolean);
  procedure UniGUIServiceStop(Sender: TService; var Stopped: boolean);
 private
  { Private declarations }
 protected
  procedure InitService; override;
 public
  { Public declarations }
  function GetServiceController: TServiceController; override;
 end;

var
 UniServiceModule: TUniServiceModule;

implementation

{$R *.dfm}

uses
 UniGUIVars;

procedure ServiceController(CtrlCode: DWord); stdcall;
begin
 UniServiceModule.Controller(CtrlCode);
end;

procedure TUniServiceModule.UniGUIServiceDestroy(Sender: TObject);
begin
 TFile.AppendAllText('D:\Temp\log.txt', 'Destroy' + #13#10);
end;

procedure TUniServiceModule.UniGUIServiceCreate(Sender: TObject);
begin
 TFile.AppendAllText('D:\Temp\log.txt', 'Create' + #13#10);
end;

function TUniServiceModule.GetServiceController: TServiceController;
begin
 Result := ServiceController;
end;

procedure TUniServiceModule.InitService;
begin
 SetServerClass(UniGUIServerModuleClass);
end;

procedure TUniServiceModule.UniGUIServiceStart(Sender: TService; var Started: boolean);
begin
 TFile.AppendAllText('D:\Temp\log.txt', 'Start' + #13#10);
 Started := True;
end;

procedure TUniServiceModule.UniGUIServiceStop(Sender: TService; var Stopped: boolean);
begin
 TFile.AppendAllText('D:\Temp\log.txt', 'Stop' + #13#10);
 Stopped := True;
end;

end.

Create
Start
Start (comment: it's wrong, must be Stop)
Destroy
 

This is code and result of how it works (the service was started after finished).

 

[Farshad Mohajeri]

Checking...

[Farshad Mohajeri]

procedure TUniGUIService._StopEvent(Sender: TService; var Stopped: Boolean);
begin
  if Assigned(FOnStop) then
    FOnStart(Sender, Stopped);

  if Stopped then
    FreeAndNil(FServerInstance);
end;

Found the problem.

In computer science it is called the Copy/Paste bug and it is root of all errors!

It will be fixed in the next build!

[Tokay]

Great! Thank you and waiting for fix.

[Tokay]

Fixed in the latest 1550, thank you!